[MCOMPILER-485] Fixes internal string format in generated package-info.class #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MCOMPILER-485
Per JVMS 4.2.1, the package name representation in the internal class structure always contains forward slashes in place of periods. This PR fixes the code from MCOMPILER-205 which passed a package name extracted from the file path which used backward slashes on Windows.
While not necessarily a cause of the bug, the javadocs for
ClassVisitor
(the superclass ofClassWriter
) state "The methods of this class must be called in the following order: visit visitSource ..." so I reordered those method calls as well.The IT is copied from MCOMPILER-205 but with a more detailed test to confirm the correct internal representation of the package name in the class file.
mvn -Prun-its clean verify
after the first (IT) commit finds the failure; note the 5c (\
) on windows vs. 2f (/
).After code fix, passes tests:
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MCOMPILER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.